config/defaults.yml (1)

506-515: Move observability: block out from between the Cron Jobs header and its key.

The new block is inserted between the # Cron Jobs Configuration comment header (lines 503–505) and the cron_jobs: mapping (line 516), visually orphaning that section header from the data it describes. While YAML parsing is unordered and this won't break OmegaConf loading, it makes the file misleading at a glance.

♻️ Suggested placement — move `observability` before the Cron Jobs section

+# ===========================
+# Observability Configuration
+# ===========================
+observability:
+  langfuse:
+    # Browser-accessible URL for linking to Langfuse sessions.
+    # Distinct from LANGFUSE_HOST which may be an internal Docker URL.
+    # Example: http://localhost:3002
+    public_url: ''
+
 # ===========================
 # Cron Jobs Configuration
 # ===========================
-# ===========================
-# Observability Configuration
-# ===========================
-observability:
-  langfuse:
-    # Browser-accessible URL for linking to Langfuse sessions.
-    # Distinct from LANGFUSE_HOST which may be an internal Docker URL.
-    # Example: http://localhost:3002
-    public_url: ''
-
 cron_jobs:

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@config/defaults.yml` around lines 506 - 515, The observability block
(observability: / langfuse: / public_url:) has been inserted between the "# Cron
Jobs Configuration" header and the cron_jobs: mapping which visually separates
the header from its section; move the entire observability: block (including
langfuse.public_url) up so it appears immediately before the Cron Jobs section
header, ensuring the "# Cron Jobs Configuration" comment is followed directly by
the cron_jobs: mapping.

services.py (1)

291-292: Use iterable unpacking instead of list concatenation (Ruff RUF005).

Static analysis flags lines 291 and 332. Line 329 has the same pattern and should be updated for consistency.

♻️ Proposed fix

-                    cmd.extend(up_flags + ['speaker-service-gpu' if profile == 'gpu' else 'speaker-service-cpu', 'web-ui'])
+                    cmd.extend([*up_flags, 'speaker-service-gpu' if profile == 'gpu' else 'speaker-service-cpu', 'web-ui'])

-                cmd.extend(up_flags + services_to_start)
+                cmd.extend([*up_flags, *services_to_start])

-                cmd.extend(up_flags + ['vibevoice-asr'])
+                cmd.extend([*up_flags, 'vibevoice-asr'])

Also applies to: 329-332

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@services.py` around lines 291 - 292, Replace list concatenation inside
cmd.extend calls with iterable unpacking or separate extends: find the
cmd.extend(up_flags + [...]) usage (the occurrences around the block that
chooses 'speaker-service-gpu' if profile == 'gpu' else 'speaker-service-cpu' and
'web-ui') and change it to either cmd.extend([*up_flags, 'speaker-service-gpu'
if profile == 'gpu' else 'speaker-service-cpu', 'web-ui']) or split into two
calls (cmd.extend(up_flags); cmd.extend(['speaker-service-gpu' if profile ==
'gpu' else 'speaker-service-cpu', 'web-ui'])); apply the same change to the
other occurrence around lines 329-332 to remove list concatenation per Ruff
RUF005.

backends/advanced/src/advanced_omi_backend/services/memory/base.py (1)

372-396: langfuse_session_id not documented in propose_memory_actions docstring

extract_memories has its new parameter documented at line 353, but the Args section of propose_memory_actions (and propose_reprocess_actions at line 414–422) was not updated to include langfuse_session_id, creating an inconsistency in the interface documentation.

📝 Proposed fix

         Args:
             retrieved_old_memory: List of existing memories for context
             new_facts: List of new facts to process
             custom_prompt: Optional custom prompt to use instead of default
+            langfuse_session_id: Optional session ID for Langfuse trace grouping
 
         Returns:

Apply the same addition to the propose_reprocess_actions docstring Args block.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backends/advanced/src/advanced_omi_backend/services/memory/base.py` around
lines 372 - 396, The docstring for propose_memory_actions is missing the
langfuse_session_id parameter documentation — update the Args section of
propose_memory_actions (and likewise propose_reprocess_actions) to document
langfuse_session_id: its type Optional[str], purpose as the Langfuse
tracing/session identifier, and that it’s optional and passed through for
observability; ensure the doc entries match the style and wording used for
extract_memories’s new parameter to keep interface docs consistent.

backends/advanced/src/advanced_omi_backend/llm_client.py (2)

199-203: _langfuse_metadata is duplicated — consolidate into openai_factory.py

An identical _langfuse_metadata helper is defined in both this file (lines 199–203) and llm_providers.py (lines 41–45). Both files already import from advanced_omi_backend.openai_factory, making it the natural home for this shared utility.

♻️ Proposed refactor

In openai_factory.py, add:

def _langfuse_metadata(session_id: str | None) -> dict:
    """Return metadata dict with langfuse_session_id if Langfuse is enabled."""
    if session_id and is_langfuse_enabled():
        return {"langfuse_session_id": session_id}
    return {}

Then in both llm_client.py and llm_providers.py, replace the local definition with:

-from advanced_omi_backend.openai_factory import create_openai_client, is_langfuse_enabled
+from advanced_omi_backend.openai_factory import create_openai_client, is_langfuse_enabled, _langfuse_metadata

and remove the local _langfuse_metadata definitions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backends/advanced/src/advanced_omi_backend/llm_client.py` around lines 199 -
203, Consolidate the duplicated helper by moving the _langfuse_metadata function
into advanced_omi_backend.openai_factory (add the function exactly as in the
diff) and update llm_client.py and llm_providers.py to import and call
openai_factory._langfuse_metadata instead of defining their own copies; then
remove the local _langfuse_metadata definitions from both files so there is a
single shared implementation to maintain.

---

243-245: langfuse_session_id is silently dropped on the singleton-client fallback path

When operation is None (or the registry is absent), async_generate and async_chat_with_tools fall back to the singleton client without forwarding langfuse_session_id. All session tracing is lost for callers that rely on the fallback path, creating inconsistent observability coverage.

♻️ Proposed fix

 # Fallback: use singleton client
 client = get_llm_client()
 loop = asyncio.get_running_loop()
-return await loop.run_in_executor(
-    None, lambda: client.generate(prompt, model, temperature)
-)
+langfuse_kwargs = _langfuse_metadata(langfuse_session_id)
+return await loop.run_in_executor(
+    None, lambda: client.generate(prompt, model, temperature, **langfuse_kwargs)
+)

Apply the same fix to the async_chat_with_tools fallback at lines 279–281.

Also applies to: 279-281

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backends/advanced/src/advanced_omi_backend/llm_client.py` around lines 243 -
245, The fallback branch in async_generate (and likewise in
async_chat_with_tools) uses run_in_executor with lambda: client.generate(prompt,
model, temperature) which drops langfuse_session_id; update both fallback calls
to pass the langfuse_session_id through to client.generate and
client.chat_with_tools (i.e., include the session_id kwarg or parameter name
used by the client) inside the lambda so the singleton-client path preserves
tracing; modify the lambda in async_generate and the similar lambda in
async_chat_with_tools to forward the langfuse_session_id argument.